Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

php-cs-fixer workflow #276

Closed
connorhu opened this issue Jan 10, 2023 · 1 comment
Closed

php-cs-fixer workflow #276

connorhu opened this issue Jan 10, 2023 · 1 comment

Comments

@connorhu
Copy link
Collaborator

connorhu commented Jan 10, 2023

As we talked about it, we could make a github action to test php coding standards (later maybe code sniffer).

This is a tested config for push event:
FriendsOfSymfony1/doctrine1@master...connorhu:doctrine1:feature/phpcsfixer
master...connorhu:symfony1:feature/phpcsfixer

I have to test it for PR event, but it works for push. When I have tested for PR I will make a pull request. The cs-fixer setting is left at minimum (only tests what @thePanz noticed to in my PR at FriendsOfSymfony1/doctrine1#94 ).
It's another question of what the setting should be at all. @symfony ruleset would be logical, but it's a very aggressive and generates a very different style from current code formatting.

We should only test the files we touch.

@thePanz
Copy link
Member

thePanz commented Dec 15, 2023

Fixed in #283

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants