Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix the result values for IR. #647

Closed
otrho opened this issue Jan 15, 2022 · 0 comments · Fixed by #828
Closed

Fix the result values for IR. #647

otrho opened this issue Jan 15, 2022 · 0 comments · Fixed by #828
Assignees
@otrho
Labels
compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request team:compiler Compiler Team

Comments

@otrho
Copy link
Contributor

otrho commented Jan 15, 2022 •
edited
Loading

In sway-core/src/optimize.rs most of the AST -> IR tranlation code is using a Result<T, String>. Since this is a part of the compiler core it should use CompileResult.

In the sway-ir crate it also uses Result<T, String> though in this case the Result is probably OK, but should use a proper error type, rather than String.
@adlerjohn adlerjohn added compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request labels Jan 15, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network Jan 15, 2022
@otrho otrho self-assigned this Jan 28, 2022
@otrho otrho mentioned this issue Feb 22, 2022
Merged
Repository owner moved this from Todo to Done in Fuel Network Feb 23, 2022
@IGI-111 IGI-111 added the team:compiler Compiler Team label Feb 10, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@otrho otrho

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request team:compiler Compiler Team
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Smaller IR changes. FuelLabs/sway
3 participants
@otrho @adlerjohn @IGI-111