Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move the IR aggregate names from Context to Module. #744

Closed
otrho opened this issue Feb 5, 2022 · 1 comment
Closed

Move the IR aggregate names from Context to Module. #744

otrho opened this issue Feb 5, 2022 · 1 comment
Labels
compiler: ir IRgen and sway-ir including optimization passes compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request team:compiler Compiler Team

Comments

@otrho
Copy link
Contributor

otrho commented Feb 5, 2022

When designing the IR I did it on the fly with heavy inspiration from LLVM. Putting the aggregate field names into the Context doesn't fit in hindsight and should instead go in the Module.

The Context should just remain to be the collection of ECS arenas used throughout the IR.
@otrho otrho added enhancement New feature or request compiler General compiler. Should eventually become more specific as the issue is triaged compiler: ir IRgen and sway-ir including optimization passes labels Feb 5, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network Feb 5, 2022
@otrho
Copy link
Contributor Author

otrho commented Feb 24, 2022

Closed by #828.

@otrho otrho closed this as completed Feb 24, 2022
Repository owner moved this from Todo to Done in Fuel Network Feb 24, 2022
@IGI-111 IGI-111 added the team:compiler Compiler Team label Feb 10, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
compiler: ir IRgen and sway-ir including optimization passes compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request team:compiler Compiler Team
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@otrho @IGI-111