Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enhancement: For the results screen after completing a full week, make it so that we can see the results from all songs separetely #2364

Open
JackXson-Real opened this issue May 8, 2024 · 3 comments
Labels
status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.

Comments

@JackXson-Real
Copy link

What should be implemented and why:

I believe that there should be a way to see the results from all songs separately after completing a full week since I feel like it would be nice to know which songs you did the worst on, and where most of the sicks or misses came from. It would definitely be a helpful QOL change that would benefit people who want the results to be more specific.

How it should be implemented:

I think the best way to implement this would be to make it so that you can use the arrow keys to switch between the results of the whole week combined, and the other songs separately as to not clutter the results screen too much.

@JackXson-Real JackXson-Real added the type: enhancement Involves an enhancement or new feature. label May 8, 2024
@amyspark-ng
Copy link
Contributor

i agree! i was gonna post about this

@EliteMasterEric EliteMasterEric added status: pending triage Awaiting review. and removed type: enhancement Involves an enhancement or new feature. labels Jun 17, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
@AbnormalPoof AbnormalPoof added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
@Lasercar
Copy link
Contributor

oof, I saw this and had a think about it - it's definitely doable, but would require modifying the highscore to not combine the tallies and instead put them in an array or something a, and then modify the results param to accept this array, start with the first song, and when it's "closed", open a results substate with the second song, and when that's closed, open the third as a substate, etc, and when the final song results substate is closed the results screen finally ends.

Making it so you can switch between the results rather than moving through them from first to last would mean making it even more complex.

If someone doesn't beat me to it first I might try doing this later (and I mean later later).

@JackXson-Real
Copy link
Author

oof, I saw this and had a think about it - it's definitely doable, but would require modifying the highscore to not combine the tallies and instead put them in an array or something a, and then modify the results param to accept this array, start with the first song, and when it's "closed", open a results substate with the second song, and when that's closed, open the third as a substate, etc, and when the final song results substate is closed the results screen finally ends.

Making it so you can switch between the results rather than moving through them from first to last would mean making it even more complex.

If someone doesn't beat me to it first I might try doing this later (and I mean later later).

I will look forward to that 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

5 participants