Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug Report: In the editor, Moving notes and returning them causes them to lose selection box #3761

Open
2 tasks done
amyspark-ng opened this issue Oct 24, 2024 · 3 comments · May be fixed by #4185
Open
2 tasks done
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.

Comments

@amyspark-ng
Copy link
Contributor

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Itch.io (Web/HTML5)

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

After selecting a bunch of notes and unselecting i can't select them again, pretty weird

selecting.notes.mp4

Steps to Reproduce

No response

@amyspark-ng amyspark-ng added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Oct 24, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Oct 25, 2024

Just played around with this a bit and found that it's something between a visual error and a serious inconvenience.

If you select a group of notes, then drag and drop them, there's a chance they'll become unhighlighted. If you then scroll down and back up to the notes, they'll be selected again. This makes it seem like the notes are "ghost-selected", but that's not the case either. If you drag and drop the notes, then try to move one note as if the group were still selected, only the single note reacts.
You can also create a bunch of different weird interactions by scrolling to view only parts of the selected group as well.

So scrolling fixes unselectable notes, but it's enough of an inconvenience and causes enough confusion to warrant a PR from one of our coder friends (much appreciated!).

@Hundrec Hundrec added topic: chart editor Related to the operation of the Chart Editor. status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. and removed status: pending triage Awaiting review. labels Jan 25, 2025
@Lasercar
Copy link
Contributor

Lasercar commented Feb 19, 2025

The yellow notes in the note preview playhead are the ones you currently have selected.

Ah, I see, sometimes you can make a selection, it selects the notes, but doesn't create the boxes used to drag them around????

I can't figure out a way to always recreate it, sometimes you do something and it removes the selection boxes from your notes but keeps them selected and deselecting and selecting them all again doesn't bring them back, however individually selecting the effected notes properly creates the selection box.

That said though, it doesn't effect the event selection, which might help pinpoint where the issue occurs.

Wait, I've just figured out a method of recreating it - end your selection over a note when you move it and put it back at the same position:

2025-02-19.23-16-37.mp4

I guess I just wasn't paying enough attention to the video in the description.

Also, undoing restores the selection boxes, which is nice to know.

Ok, I might have figured out a fix?

@Lasercar
Copy link
Contributor

Lasercar commented Feb 19, 2025

This issue now has a pending PR. (Yay! I fixed it! I thought I wouldn't be able to fix this)

Also, this issue could use a rename to better reflect how/what causes the issue to happen - moving the notes but returning them to the same position and releasing, causes the selected notes to lose their selection boxes.

@amyspark-ng amyspark-ng changed the title Bug Report: You can't select multiple notes after selecting them once (chart editor) Bug Report: In the editor, Moving notes and returning them causes them to lose selection box Feb 19, 2025
@Hundrec Hundrec added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. labels Feb 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@Lasercar @amyspark-ng @Hundrec and others