Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enhancement: Hold note context menu has an input for the hold note's length #4197

Open
3 tasks done
Lasercar opened this issue Feb 21, 2025 · 4 comments · May be fixed by #4200
Open
3 tasks done

Enhancement: Hold note context menu has an input for the hold note's length #4197

Lasercar opened this issue Feb 21, 2025 · 4 comments · May be fixed by #4200
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.

Comments

@Lasercar
Copy link
Contributor

Issue Checklist

  • I have read the Contributing Guide
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested
  • I have properly titled my enhancement

What is your suggestion, and why should it be implemented?

Title.

I'll investigate doing this later.
@Lasercar Lasercar added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Feb 21, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 21, 2025

This would be nice!
Could it have both step and ms units?

@Hundrec Hundrec added the topic: chart editor Related to the operation of the Chart Editor. label Feb 21, 2025
@Lasercar
Copy link
Contributor Author

This would be nice! Could it have both step and ms units?

Sure. I should be able to figure out a way to to this. Should it be two separate boxes, or a single box and there's a button/dropdown to change it from steps to milliseconds and vice versa?

And while I'm add it I might as well figure out how to display and change the position of the note as well.

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 22, 2025

Dropdown sounds ideal

@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 22, 2025 •
edited
Loading

Here's a little appetiser...

2025-02-22.13-01-41.mp4

@Lasercar Lasercar linked a pull request Feb 22, 2025 that will close this issue
Open
@AbnormalPoof AbnormalPoof added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: pending triage Awaiting review. labels Feb 22, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chart editor - Improved context menus Lasercar/Funkin
3 participants
@Lasercar @AbnormalPoof @Hundrec