Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Usage of python list as odml value circumvents dtype checks #227

Closed
mpsonntag opened this issue Feb 22, 2018 · 0 comments · Fixed by #237
Closed

Usage of python list as odml value circumvents dtype checks #227

mpsonntag opened this issue Feb 22, 2018 · 0 comments · Fixed by #237
Assignees

Comments

@mpsonntag
Copy link
Contributor

Since we removed the odml.Value class and simply replaced it with a python list, this list provides of course methods like append which in turn ignores all the nice dtype checks we would like to have in place to keep odML values consistent.

As an example this currently works w/o any error:

p = odml.Property(name="example", dtype=odml.DType.int, value=[2, 4, 16, 23, 42])
p.value.append("lame ending")
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants