Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cuboid>translate.py unused variables and imports #33

Closed
repositony opened this issue Mar 27, 2024 · 2 comments
Closed

Cuboid>translate.py unused variables and imports #33

repositony opened this issue Mar 27, 2024 · 2 comments

Comments

@repositony
Copy link
Contributor

Couple of unused code in this file, may want to remove them if it was intended:

  • dist1 and dist2 are never used.
def isInverted(solid):
    face = solid.Faces[0]
    Range = face.ParameterRange
    u = (Range[1] + Range[0]) / 2.0
    v = (Range[3] + Range[2]) / 2.0

    dist1 = face.CenterOfMass.distanceToPoint(solid.BoundBox.Center)
    dist2 = face.CenterOfMass.add(face.normalAt(u, v).multiply(1.0e-6)).distanceToPoint(
        solid.BoundBox.Center
    )
    point2 = face.CenterOfMass.add(face.normalAt(u, v).multiply(1.0e-6))

    if solid.isInside(point2, 1e-7, False):
        return True
    else:
        return False
  • half of these imports are never used (isInLine, signPlane, isSameValue)
from GEOUNED.Utils.BasicFunctions_part1 import (
    isParallel,
    isOposite,
    isInLine,
    signPlane,
    isSameValue,
)
@repositony repositony changed the title Cuboid>translate.py issues Cuboid>translate.py unused variables and imports Mar 27, 2024
@repositony
Copy link
Contributor Author

See PR #35

@repositony
Copy link
Contributor Author

Merged in commit 4db7ce2

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant