[376] Evaluator Dashboard #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
stepchud
reviewed
Feb 24, 2025
Comment on lines
18
to
19
| <%= assigned_submissions_count(current_user, phase.challenge, phase) %> of | ||
| <%= remaining_evaluations_count(current_user, phase.challenge, phase) %> |
There was a problem hiding this comment.
the numbers are reversed and should be "# remaining of # assigned"
There was a problem hiding this comment.
I agree that the numbers are reversed but I don't see that "# remaining of # assigned" copy on figma
https://www.figma.com/design/sLkJM1Ua9Zu3HW2h4mVdgr/Challenge.gov-Eval-(Updated-01%2F27%2F25)?node-id=7003-101843&p=f&t=DtwB5qvxhn4HKLYv-0
for me it looks like it should be "# of # Submissions"
There was a problem hiding this comment.
yes sorry, that's what I meant. the "# remaining" is just the number itself, the string format you see on figma is correct. 👍
stepchud
reviewed
Feb 24, 2025
|
Can you also add some specs for this view (a11y and content validation)? |
Merged
stepchud
reviewed
Feb 25, 2025
stepchud
reviewed
Feb 25, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the evaluator dashboard to the latest designs.