-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[405] Non-gov access for Challenge Managers on Rails #448
Conversation
…/Challenge_platform into 405/non-gov-access-to-info-challenge-managers * '72/non-gov-access-to-info-evaluators' of github.com:GSA/Challenge_platform: Update preloading the associations for sorting indentation indentation code climate Remove redundant test and expand average score sorting spec 418 | Scope assigned evaluators and avg score code climate 418 | Only sort average score of submissions with evaluation status of completed 418 | Use preload to avoid sql error for the assignee sort view WIP sorting by assignee count, blocked by evaluation_status
…access-to-info-challenge-managers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm able to navigate to the route /phases/:phase_id/evaluator_submission_assignments?evaluator_id=:user_id
, let's protect that whole controller with before_action -> { check_gov_access }
too
…/Challenge_platform into 405/non-gov-access-to-info-challenge-managers * '72/non-gov-access-to-info-evaluators' of github.com:GSA/Challenge_platform: 72 Clean up specs [442] Nav & Accordion Color Updates (#447) Refactors per rubocop and codeclimate Remove Rails Proxy and use Faraday Update CI for same ruby patch update Permit patch level ruby changes in Gemfile, update ruby version for buildpack override default theme colors Update alt text Fix mailer template accessibility and color override Bump webmock from 3.24.0 to 3.25.0
…b.com:GSA/Challenge_platform into 405/non-gov-access-to-info-challenge-managers * '405/non-gov-access-to-info-challenge-managers' of github.com:GSA/Challenge_platform: remove code comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍
…b.com:GSA/Challenge_platform into 405/non-gov-access-to-info-challenge-managers * '405/non-gov-access-to-info-challenge-managers' of github.com:GSA/Challenge_platform:
#405