Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[405] Non-gov access for Challenge Managers on Rails #448

Merged
merged 13 commits into from
Mar 4, 2025

Conversation

cpreisinger
Copy link
Contributor

@cpreisinger cpreisinger requested a review from stepchud February 26, 2025 21:25
@cpreisinger cpreisinger self-assigned this Feb 26, 2025
…/Challenge_platform into 405/non-gov-access-to-info-challenge-managers

* '72/non-gov-access-to-info-evaluators' of github.com:GSA/Challenge_platform:
  Update preloading the associations for sorting
  indentation
  indentation
  code climate
  Remove redundant test and expand average score sorting spec
  418 | Scope assigned evaluators and avg score
  code climate
  418 | Only sort average score of submissions with evaluation status of completed
  418 | Use preload to avoid sql error for the assignee sort view
  WIP sorting by assignee count, blocked by evaluation_status
@stepchud stepchud linked an issue Mar 3, 2025 that may be closed by this pull request
44 tasks
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to navigate to the route /phases/:phase_id/evaluator_submission_assignments?evaluator_id=:user_id, let's protect that whole controller with before_action -> { check_gov_access } too

…/Challenge_platform into 405/non-gov-access-to-info-challenge-managers

* '72/non-gov-access-to-info-evaluators' of github.com:GSA/Challenge_platform:
  72 Clean up specs
  [442] Nav & Accordion Color Updates (#447)
  Refactors per rubocop and codeclimate
  Remove Rails Proxy and use Faraday
  Update CI for same ruby patch update
  Permit patch level ruby changes in Gemfile, update ruby version for buildpack
  override default theme colors
  Update alt text
  Fix mailer template accessibility and color override
  Bump webmock from 3.24.0 to 3.25.0
…b.com:GSA/Challenge_platform into 405/non-gov-access-to-info-challenge-managers

* '405/non-gov-access-to-info-challenge-managers' of github.com:GSA/Challenge_platform:
  remove code comment
@cpreisinger cpreisinger requested a review from stepchud March 3, 2025 20:42
Base automatically changed from 72/non-gov-access-to-info-evaluators to dev March 3, 2025 21:08
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@stepchud stepchud merged commit 3e60b73 into dev Mar 4, 2025
11 checks passed
@stepchud stepchud deleted the 405/non-gov-access-to-info-challenge-managers branch March 4, 2025 19:35
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 03/11/25 milestone Mar 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-gov access for Challenge Managers on Rails
3 participants