Update print_to_gt.R to put RTF footnotes in the document footer by default #485
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alanahjonas95 Thanks!! Can you please check this does what we want for saving to RTF, and doesn't impact other outputs? You could use {tfrmtbuilder} to make this quicker! |
|
@bzkrouse just made this quickly with tfrmtbuilder as suggested :) |
|
@alanahjonas95 Perfect thank you!! One more thing, can you please add to the NEWS file ? Then we should be good to go. |
I've updated the read me but wasn't sure if i should mark as a bug fix or an improvement? and will the next release be 0.1.4? |
bzkrouse
reviewed
Dec 3, 2024
bzkrouse
reviewed
Dec 3, 2024
Co-authored-by: Becca Krouse <14199771+bzkrouse@users.noreply.github.com>
Co-authored-by: Becca Krouse <14199771+bzkrouse@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #422