Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Request]: Disabling/enabling hash functions #166

Open
1 task done
begin-theadventure opened this issue Sep 23, 2023 · 2 comments
Open
1 task done

[Request]: Disabling/enabling hash functions #166

begin-theadventure opened this issue Sep 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@begin-theadventure
Copy link

begin-theadventure commented Sep 23, 2023

Describe the request

... -> Settings: toggles for disabling/enabling sums.
This feature would be useful for larger files, as it would speed up the calculation process.
I also usually only need one type of hash.

Implementation Details

@begin-theadventure begin-theadventure added the enhancement New feature or request label Sep 23, 2023
@begin-theadventure begin-theadventure changed the title [Request]: Disabling/enabling hash functions. [Request]: Disabling/enabling hash functions Sep 24, 2023
@GeopJr
Copy link
Owner

GeopJr commented Nov 13, 2023

It does sound good but we need to figure out how to do the file comparison. Right now, it calculates the sah256 hash of the selected file and checks against the open one's sha256 hash.

As it stands, I only see three options:

  • Don't allow sha256 to be disabled and keep the comparison as is
  • Calculate the sha256 hash of both the open file and the one that was just picked when it gets picked and keep the comparison as is - ❌ I don't like this, if the open file is big it will take longer
  • Use one of the enabled hash functions for the picked file and compare it to the open one - :/ not sure about this one either, while it makes the most sense, if the only available hash functions is one that is very prone to collisions, it'll be insecure and wrong (like MD5)

@m3thm4th
Copy link

m3thm4th commented Oct 11, 2024

we need to figure out how to do the file comparison

Add a menu of checkboxes for the user to decide each time which functions should be enabled/disabled. the comparison will be made against that.

if the only available hash functions is one that is very prone to collisions, it'll be insecure and wrong (like MD5)

A warning to the user should be enough, although I doubt someone using this software would need it.

I agree it is very time-consuming and inefficient when checking large files.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants