Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for AbortController #284

Open
2 tasks done
josephschmitt opened this issue Apr 7, 2022 · 1 comment
Open
2 tasks done

Add support for AbortController #284

josephschmitt opened this issue Apr 7, 2022 · 1 comment
Labels
feature request New feature or request

Comments

@josephschmitt
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

The JavaScript AbortController allows the cancellation of an in-flight fetch request. The current @giphy/js-fetch-api doesn't expose an option to pass an AbortController .abort() function or a signal to fetch itself.

Motivation 🔦

If this was integrated, SDK users would be able to abort in-flight requests (such as if the user starts a search, pauses, and then continues typing)

@josephschmitt josephschmitt added the feature request New feature or request label Apr 7, 2022
@giannif
Copy link
Collaborator

giannif commented Apr 11, 2022

@josephschmitt this is a cool idea, we'll create a ticket and investigate 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants