Fixing xmlnames #16
Merged
Fixing xmlnames #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit is fine and fixes the different namespaces of attributes from extension very well. I am tempted to merge just the second commit to get us closer to stability. I am sorry for the merge conflicts. |
|
The tests here pass, in scap they failed because they failed to pull the schemas? I'll take another look in the morning. |
* gocomply/master: Add stock XMLDSIG schema to our test suite Make tests more flexible: do not rely on XSD defining simple_schema/models.go Smoke test should assert that generated is valid golang file All the smoke tests should compare output to pre-generated files Test: Rename output files used for assertions Rewrite deduplication of inherited elements Do not import "encoding/xml" if schema includes only simple types Ensure that schema without elements is exported just fine Do export schema that contains only simple types Implement missing plain types
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of issues: