Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Unused statement on CacheBitmapV3 #377

Open
gninjamaster opened this issue Dec 6, 2021 · 1 comment
Open

Unused statement on CacheBitmapV3 #377

gninjamaster opened this issue Dec 6, 2021 · 1 comment
Labels
help wanted Extra attention is needed investigate Needs more thought / experience

Comments

@gninjamaster
Copy link

CacheBitmapV3 unused statement
The line above is overridden by line #239 and never used.
There is a note on the statement, not sure if was intended to be a TODO
@obilodeau
Copy link
Collaborator

Anything that interacts with CacheBitmap (parent class) could access its bpp. Did you verify for all accessors' code paths? Unless I have a better test case I'm tempted to leave everything as is.

@obilodeau obilodeau added help wanted Extra attention is needed investigate Needs more thought / experience labels Jan 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed investigate Needs more thought / experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obilodeau @gninjamaster