Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optional Dependencies #122

Closed
3 tasks
Tracked by #181
KANAjetzt opened this issue Feb 22, 2023 · 4 comments
Closed
3 tasks
Tracked by #181

Optional Dependencies #122

KANAjetzt opened this issue Feb 22, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@KANAjetzt
Copy link
Member

KANAjetzt commented Feb 22, 2023

Make it possible to mark a mod as optional dependency.

  • loop through optional_dependencies
  • check if mod_id exists
  • if so increase importance score by 1
@KANAjetzt KANAjetzt added the enhancement New feature or request label Feb 22, 2023
@KANAjetzt
Copy link
Member Author

From the Space Potatoes Discord

damzo — Today at 12:35
i think with this utility mod it would be better to have ContentLoader alongside but i'm not too sure how to go about it, since it's not exactly required either. just recommended

@ithinkandicode
Copy link
Collaborator

It sounds like the way to implement this is with a manifest extra.godot key that has no functionality, but only exists as a point of reference, either to other modders or as data that a mod/game can use in-game. Would that be correct?

@KANAjetzt
Copy link
Member Author

I think if the optional dependency mod is installed, the dependency should load before the depending mod.
So we still check if the dependency exists, we just don't prevent the mod from loading if the dependency is missing.

@KANAjetzt KANAjetzt mentioned this issue Mar 23, 2023
37 tasks
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Mar 23, 2023
@KANAjetzt KANAjetzt self-assigned this Mar 24, 2023
@KANAjetzt
Copy link
Member Author

closed by #188

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants