Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Filter by groups and snapshots #299

Open
foolip opened this issue May 19, 2024 · 2 comments · Fixed by #603, #602, #601, #600 or #599
Open

Filter by groups and snapshots #299

foolip opened this issue May 19, 2024 · 2 comments · Fixed by #603, #602, #601, #600 or #599
Assignees
@jcscottiii
Labels
enhancement New feature or request go Pull requests that update Go code

Comments

@foolip
Copy link
Member

foolip commented May 19, 2024

After web-platform-dx/web-features#1060 it would be good to have these filters:

  • group:css to list all features that are directly or indirectly part of the CSS group. Since a feature can be part of multiple groups, the simplest way to implement this is probably to generate a list of groups per feature by walking the group parent chain. Then there's no need for the search feature to understand the hierarchy.
  • snapshot:ecmascript-2015 to list all features in ECMAScript 2015. There's no hierarchy here.

This would address some use cases in #276.

cc @hvanops
@jcscottiii jcscottiii added enhancement New feature or request go Pull requests that update Go code blocked:upstream-data Blocked on correcting or adding upstream data labels May 23, 2024
@jcscottiii jcscottiii removed the blocked:upstream-data Blocked on correcting or adding upstream data label Jul 10, 2024
@jcscottiii
Copy link
Collaborator

This data is now available with web-platform-dx/web-features#1060

@jcscottiii jcscottiii self-assigned this Aug 12, 2024
@jcscottiii jcscottiii mentioned this issue Aug 15, 2024
Merged
jcscottiii added a commit that referenced this issue Aug 16, 2024
@jcscottiii
Add support for WebDX Snapshot, Feature-Snapshot Mappings
39caaf7 
**Description:**

This PR introduces the foundational schema and data access layer for managing WebDX Snapshots and their associations with Web Features in Spanner. This is the second half of #299 to support only the snapshot storage and filtering.

**Note**: Unlike groups, snapshots do not have any hiearchy. So it is a little simpler.

**Key Changes**

* **Schema:**
   * Created the `WebDXSanpshots` table to store snapshot metadata.
   * Created the `WebFeatureSanpshots` table to map web features to their associated snapshots.

* **Data Access Layer:**
   * Implemented `UpsertSnapshot` and `GetSnapshotIDFromSnapshotKey` methods in the `Client` struct to interact with the `WebDXSnapshots` table.
   * Implemented `UpsertWebFeatureSnapshot` to manage feature-snapshot mappings in the `WebFeatureSnapshots` table.
   * Introduced helper structs and mappers (`WebFeatureSnapshot`, `snapshotSpannerMapper`, etc.) to facilitate data mapping and persistence.

**Purpose**

* Enables storing and retrieving information about WebDX Snapshots and their relationships with Web Features.
* Lays the groundwork for future features that rely on snapshot-based storage and filtering.
@jcscottiii jcscottiii mentioned this issue Aug 16, 2024
Merged
jcscottiii added a commit that referenced this issue Aug 17, 2024
@jcscottiii
Add support for WebDX Snapshot, Feature-Snapshot Mappings
43b7f66 
**Description:**

This PR introduces the foundational schema and data access layer for managing WebDX Snapshots and their associations with Web Features in Spanner. This is the second half of #299 to support only the snapshot storage and filtering.

**Note**: Unlike groups, snapshots do not have any hiearchy. So it is a little simpler.

**Key Changes**

* **Schema:**
   * Created the `WebDXSanpshots` table to store snapshot metadata.
   * Created the `WebFeatureSanpshots` table to map web features to their associated snapshots.

* **Data Access Layer:**
   * Implemented `UpsertSnapshot` and `GetSnapshotIDFromSnapshotKey` methods in the `Client` struct to interact with the `WebDXSnapshots` table.
   * Implemented `UpsertWebFeatureSnapshot` to manage feature-snapshot mappings in the `WebFeatureSnapshots` table.
   * Introduced helper structs and mappers (`WebFeatureSnapshot`, `snapshotSpannerMapper`, etc.) to facilitate data mapping and persistence.

**Purpose**

* Enables storing and retrieving information about WebDX Snapshots and their relationships with Web Features.
* Lays the groundwork for future features that rely on snapshot-based storage and filtering.
github-merge-queue bot pushed a commit that referenced this issue Aug 17, 2024
@jcscottiii
Add support for WebDX Snapshot, Feature-Snapshot Mappings (#599)
01920a8 
**Description:**

This PR introduces the foundational schema and data access layer for managing WebDX Snapshots and their associations with Web Features in Spanner. This is the second half of #299 to support only the snapshot storage and filtering.

**Note**: Unlike groups, snapshots do not have any hiearchy. So it is a little simpler.

**Key Changes**

* **Schema:**
   * Created the `WebDXSanpshots` table to store snapshot metadata.
   * Created the `WebFeatureSanpshots` table to map web features to their associated snapshots.

* **Data Access Layer:**
   * Implemented `UpsertSnapshot` and `GetSnapshotIDFromSnapshotKey` methods in the `Client` struct to interact with the `WebDXSnapshots` table.
   * Implemented `UpsertWebFeatureSnapshot` to manage feature-snapshot mappings in the `WebFeatureSnapshots` table.
   * Introduced helper structs and mappers (`WebFeatureSnapshot`, `snapshotSpannerMapper`, etc.) to facilitate data mapping and persistence.

**Purpose**

* Enables storing and retrieving information about WebDX Snapshots and their relationships with Web Features.
* Lays the groundwork for future features that rely on snapshot-based storage and filtering.
This was linked to pull requests Aug 19, 2024
[5/5] Add fake snapshots to dev fake data #603
Merged
[4/5] Use new WebFeatureSnapshotConsumer in workflow #602
Merged
[3/5] Add Support for Snapshot-Based Feature Search #601
Merged
[2/5] Implement Web Feature Snapshots Consumer #600
Merged
[1/5] Add support for WebDX Snapshot & Feature-Snapshot Mappings #599
Merged
[4/4] Add fake groups to dev fake data #597
Merged
[3/4] Add Support for Group-Based Feature Search #596
Merged
[2/4] Implement Web Feature Groups Consumer #595
Merged
[1/4] Add support for WebDX Groups, Feature-Group Mappings & Group Descendants #594
Merged
@jcscottiii
Copy link
Collaborator

jcscottiii commented Aug 19, 2024 •
edited
Loading

Filtering by groups and snapshot works if the user types the query directly. The work to add it to the autocomplete will be in this separate issue

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jcscottiii jcscottiii

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
webstatus.dev
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5/5] Add fake snapshots to dev fake data GoogleChrome/webstatus.dev
[4/5] Use new WebFeatureSnapshotConsumer in workflow GoogleChrome/webstatus.dev
[3/5] Add Support for Snapshot-Based Feature Search GoogleChrome/webstatus.dev
[2/5] Implement Web Feature Snapshots Consumer GoogleChrome/webstatus.dev
[1/5] Add support for WebDX Snapshot & Feature-Snapshot Mappings GoogleChrome/webstatus.dev
[4/4] Add fake groups to dev fake data GoogleChrome/webstatus.dev
[3/4] Add Support for Group-Based Feature Search GoogleChrome/webstatus.dev
[2/4] Implement Web Feature Groups Consumer GoogleChrome/webstatus.dev
[1/4] Add support for WebDX Groups, Feature-Group Mappings & Group Descendants GoogleChrome/webstatus.dev
2 participants
@foolip @jcscottiii