Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hardcoded "In the future, this error screen could provide you with actions you can perform while offline..." message #1025

Open
claudiulodro opened this issue Jul 20, 2023 · 1 comment

Comments

@claudiulodro
Copy link

We recently passed the 4 year anniversary of this message being part of the Offline screen! 🎉 It is hard-coded into the offline template and not super simple to remove on a site, so I am curious if it is still relevant or if there are concrete plans to surface recent cached posts or something on that screen. If not, I think it probably makes sense to remove that line, especially since I imagine the majority of people that see the screen are site visitors who don't know what it means to be able to "edit recent drafts in Gutenberg".

@westonruter
Copy link
Collaborator

Actually, that error message regarding editing drafts in Gutenberg is restricted to the offline page served to the wp-admin. So it shouldn't be shown to site visitors on the frontend.

Regardless, there aren't concrete plans so this line could be deleted:

$content .= sprintf( '<p>%s</p>', esc_html__( 'In the future, this error screen could provide you with actions you can perform while offline, like edit recent drafts in Gutenberg.', 'pwa' ) );

@westonruter westonruter added this to the 0.8 milestone Jul 21, 2023
@westonruter westonruter modified the milestones: 0.8, 0.9 Jan 24, 2024
@westonruter westonruter modified the milestones: 0.8.1, 0.9 Apr 2, 2024
@westonruter westonruter removed this from the 0.8.2 milestone Nov 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants