Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make classes final #340

Closed
westonruter opened this issue Oct 13, 2020 · 0 comments · Fixed by #360
Closed

Make classes final #340

westonruter opened this issue Oct 13, 2020 · 0 comments · Fixed by #360
Labels
bug Something isn't working changelogged
Milestone
0.6

Comments

@westonruter
Copy link
Collaborator

I just noticed that classes like WP_Service_Worker_Caching_Routes are not marked as final:

pwa-wp/wp-includes/components/class-wp-service-worker-caching-routes.php

Line 13 in 230ed8f

class WP_Service_Worker_Caching_Routes implements WP_Service_Worker_Registry {

All classes that are not intended to be extended should be marked as final.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working changelogged
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Make all classes final since not intended to be extended GoogleChromeLabs/pwa-wp
1 participant
@westonruter