Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fail silently, don’t throw an error, when IntersectionObserver isn’t available #113

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Fail silently, don’t throw an error, when IntersectionObserver isn’t available #113

merged 1 commit into from
Aug 6, 2019

Conversation

dieulot
Copy link
Contributor

@dieulot dieulot commented Jul 30, 2019

This avoids throwing an error on Safari ≤ 12.0.

addyosmani
addyosmani approved these changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this tweak in behaviour overall. Thanks!

@addyosmani addyosmani merged commit 32e5b61 into GoogleChromeLabs:master Aug 6, 2019
@dependabot-preview dependabot-preview bot mentioned this pull request Sep 23, 2019
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Sep 30, 2019
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 16, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addyosmani addyosmani addyosmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dieulot @addyosmani