Introduce prefetch chunks build #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [fix] unit tests for prefetchchunks * [chore] cleaned up console logs * [infra] default accessor argument added
* [fix] mistyped expected value * [chore] debugging prefetch chunks test * [chore] debugging with normal JS functions * [chore] debugging by adding a real css file * [chore] debugging * [chore] debugging * [chore] debugging * [chore] debugging * [chore] debugging * [chore] debugging * [chore] debugging * [chore] debugging * [chore] debugging tests * [chore] debugging tests * [chore] cleaned up
|
@addyosmani cc @demianrenzulli LGTM! |
|
Just went through the code and couldn't find any issues there, so it LGTM too 👍 |
|
Thank you, @anton-karlovskiy and @demianrenzulli! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #156 which adds support for prefetch chunks as a separate build. The goal of this build is to give developers who are building single-page applications to logic required to do so, without requiring all users to pay the extra byte-costs.