Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PubSub]: Avro schema test are flaky #1588

Open
amanda-tarafa opened this issue Jan 12, 2022 · 3 comments
Open

[PubSub]: Avro schema test are flaky #1588

amanda-tarafa opened this issue Jan 12, 2022 · 3 comments
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@amanda-tarafa
Copy link
Member

Examples of failures here and here

@amanda-tarafa amanda-tarafa added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. api: pubsub Issues related to the Pub/Sub API. api: appengine Issues related to the App Engine Admin API API. labels Jan 12, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 13, 2022
@meredithslota meredithslota added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: process A process-related concern. May include testing, release, or the like. labels Nov 16, 2022
@amanda-tarafa
Copy link
Member Author

More info here but copying details as retention on those logs may expire:

Failed CreateAvroSchemaTest.CreateAvroSchema [292 ms]
  Error Message:
   Assert.Equal() Failure
Expected: { "name": "projects/dotnet-docs-samples-tests/schemas/testAvroSchemaForSchemaCreation67371676-2904-47a2", "type": "AVRO", "definition": "{\r\n  \"type\":\"record\",\r\n  \"name\":\"State\",\r\n  \"namespace\":\"utilities\",\r\n  \"doc\":\"A list of states in the United States of America.\",\r\n  \"fields\":[\r\n    {\r\n      \"name\":\"name\",\r\n      \"type\":\"string\",\r\n      \"doc\":\"The common name of the state.\"\r\n    },\r\n    {\r\n      \"name\":\"post_abbr\",\r\n      \"type\":\"string\",\r\n      \"doc\":\"The postal code abbreviation of the state.\"\r\n    }\r\n  ]\r\n}\r\n" }
Actual:   { "name": "projects/dotnet-docs-samples-tests/schemas/testAvroSchemaForSchemaCreation67371676-2904-47a2", "type": "AVRO", "definition": "{\r\n  \"type\":\"record\",\r\n  \"name\":\"State\",\r\n  \"namespace\":\"utilities\",\r\n  \"doc\":\"A list of states in the United States of America.\",\r\n  \"fields\":[\r\n    {\r\n      \"name\":\"name\",\r\n      \"type\":\"string\",\r\n      \"doc\":\"The common name of the state.\"\r\n    },\r\n    {\r\n      \"name\":\"post_abbr\",\r\n      \"type\":\"string\",\r\n      \"doc\":\"The postal code abbreviation of the state.\"\r\n    }\r\n  ]\r\n}\r\n", "revisionId": "9deb0199", "revisionCreateTime": "2023-01-28T04:12:52.182Z" }
  Stack Trace:
     at CreateAvroSchemaTest.CreateAvroSchema() in T:\src\github\dotnet-docs-samples\pubsub\api\Pubsub.Samples.Tests\CreateAvroSchemaTest.cs:line 36
Failed CreateProtoSchemaTest.CreateProtoSchema [160 ms]
  Error Message:
   Assert.Equal() Failure
Expected: { "name": "projects/dotnet-docs-samples-tests/schemas/testProtoSchemaForSchemaCreation5e0ac587-bd93-4fd0", "type": "PROTOCOL_BUFFER", "definition": "syntax = \"proto3\";\r\n\r\npackage utilities;\r\noption java_outer_classname = \"StateProto\";\r\n\r\nmessage State {\r\n  string name = 1;\r\n  string post_abbr = 2;\r\n}\r\n" }
Actual:   { "name": "projects/dotnet-docs-samples-tests/schemas/testProtoSchemaForSchemaCreation5e0ac587-bd93-4fd0", "type": "PROTOCOL_BUFFER", "definition": "syntax = \"proto3\";\r\n\r\npackage utilities;\r\noption java_outer_classname = \"StateProto\";\r\n\r\nmessage State {\r\n  string name = 1;\r\n  string post_abbr = 2;\r\n}\r\n", "revisionId": "0a8a452d", "revisionCreateTime": "2023-01-28T04:12:55.870Z" }
  Stack Trace:
     at CreateProtoSchemaTest.CreateProtoSchema() in T:\src\github\dotnet-docs-samples\pubsub\api\Pubsub.Samples.Tests\CreateProtoSchemaTest.cs:line 36

@Rishabh-V
Copy link
Contributor

Assigning to @hemanshv as he has worked on AppEngine/PubSub samples in the past. I will work with him as needed.

@amanda-tarafa amanda-tarafa changed the title [appengine/PubSub]: Tests are flaky [PubSub]: Tests are flaky Jun 9, 2023
@amanda-tarafa amanda-tarafa added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed api: appengine Issues related to the App Engine Admin API API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 9, 2023
@amanda-tarafa
Copy link
Member Author

Downgrading to P3, we have explored options internally and still we don't have much to go on. We'll keep the issue open for 6 more months to see if this happens again, else we'll close it as transient.

@amanda-tarafa amanda-tarafa changed the title [PubSub]: Tests are flaky [PubSub]: Avro schema test are flaky Jun 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

7 participants
@meredithslota @amanda-tarafa @Rishabh-V @anshuldavid13 @shivgautam @hemanshv and others