Skip to content

refactor!: rename cloudevent to CloudEvent #379

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

matthewrobertson
Copy link
Member

This commit is a refactor of all our CloudEvent identifiers to be more
consistent. Depending on the context we will always prefer: CloudEvent,
cloudEvent, or cloud_event. We will avoid cloudevent

Fixes #378

This commit is a refactor of all our cloudevent identifiers to be more
consistent. Depending on the context we will always prefer: `CloudEvent`,
`cloudEvent`, or `cloud_event`. We will avoid `cloudevent`

Fixes #378
@matthewrobertson matthewrobertson merged commit 11d35b3 into master Nov 5, 2021
@release-please release-please bot mentioned this pull request Nov 5, 2021
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I believe cloud_events should be cloudevents since CloudEvents is one word, not Cloud Events.

For example:

  • experimental/generate_cloud_events/README.md
  • -> experimental/generate_cloudevents/README.md

@matthewrobertson matthewrobertson deleted the cloud-event-rename branch December 7, 2021 20:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudEvent registration method should be camelCase
3 participants