Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENABLE_STATS doesn't do anything #2399

Closed
scarolan opened this issue Feb 29, 2024 · 2 comments
Closed

ENABLE_STATS doesn't do anything #2399

scarolan opened this issue Feb 29, 2024 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@scarolan
Copy link

The README suggests ENABLE_STATS to have the app export metrics to OTLP. This environment variable doesn't seem to do anything, I was unable to find any mentions of it in the go code. Was this something that was intended to be implemented but never completed?

https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/kustomize/components/google-cloud-operations/README.md#changes

When enabling this kustomize module, most services will be patched with a configuration similar to the following:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: productcatalogservice
spec:
  template:
    spec:
      containers:
        - name: server
          env:
          - name: COLLECTOR_SERVICE_ADDR
            value: "opentelemetrycollector:4317"
          - name: ENABLE_STATS
            value: "1"
          - name: ENABLE_TRACING
            value: "1"
@bourgeoisor bourgeoisor added type: question Request for information or clarification. Not an issue. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Apr 17, 2024
@bourgeoisor
Copy link
Member

bourgeoisor commented Apr 17, 2024

cc: @NimJay @arbrown do either of you know the answer to this question?

It does indeed look like these variables don't show up anywhere in the code, e.g.:
image

@scarolan
Copy link
Author

This is a year old, I don't think Google cares enough to fix it. Closing issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

2 participants