-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add docs session to noxfile #202
Add docs session to noxfile #202
Conversation
To merge after googleapis/gapic-generator#2619 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; tiny nit asking for clarification around the "Build the docs" comment.
|
||
@nox.session(python="3.7") | ||
def docs(session): | ||
"""Build the docs.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this builds the docs for python libraries specifically? so would this be run as part of the nightly synthtool
run on google-cloud-python
as an example?
might be worth fleshing out the comment slightly more to call this out: "generates docs for python libraries nightly"?
will generating docs for other languages require the similar addition of a noxfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These templates only get used for the Python monorepo, google-cloud-python. Docs currently get built all together at the top level.
With this addition to the noxfile, you can go to a specific subdirectory like google-cloud-python/tasks
, run nox -s docs
and generate documentation for just that package. This is needed for googleapis.dev, which wants docsets by package. It's also faster than building all of the docs.
This won't run in any nightly/release builds right now, but it will be in release builds once Python is ready to move to googleapis.dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 awesome, thanks for clarifying.
No description provided.