Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add anchor so that we can link directly to reference docs #268

Merged
merged 3 commits into from
Jun 25, 2019
Merged

feat: add anchor so that we can link directly to reference docs #268

merged 3 commits into from
Jun 25, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jun 25, 2019

Adds an anchor, so that when linking out to googleapis.dev, we can link directly to the section of the page that has reference docs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2019
JustinBeckwith
JustinBeckwith approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be really nice to:

  1. Run the autosynth nodejs job today manually first
  2. Land this change
  3. Run autosynth nodejs right away so we are insulated from other changes
  4. Use repo rename | approve | merge to get all these in with the hammer

@bcoe
Copy link
Contributor Author

bcoe commented Jun 25, 2019

@JustinBeckwith, I've got a mass PR ready to go, which uses synthtool.

@bcoe bcoe merged commit 367efa9 into master Jun 25, 2019
@bcoe bcoe deleted the reference-docs-links branch June 25, 2019 20:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcoe @JustinBeckwith @googlebot