Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: use index as key on line break #74

Merged
merged 2 commits into from
Mar 22, 2022
Merged

chore: use index as key on line break #74

merged 2 commits into from
Mar 22, 2022

Conversation

jpedroschmitz
Copy link
Contributor

Changes the key from line to index. Since line will be empty all the time, using the index is the best alternative here.

This fixes the same keys warning from React.

Closes #70

@jpedroschmitz jpedroschmitz added bug Something isn't working react-renderer Issues and PR's related to @graphcms/rich-text-react-renderer labels Mar 22, 2022
@jpedroschmitz jpedroschmitz self-assigned this Mar 22, 2022
@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2022

🦋 Changeset detected

Latest commit: de18596

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphcms/rich-text-react-renderer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpedroschmitz jpedroschmitz requested a review from feychenie March 22, 2022 10:26
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js 5.13 KB (0%)
packages/react-renderer/dist/rich-text-react-renderer.esm.js 5.09 KB (-0.02% 🔽)
packages/types/dist/rich-text-types.cjs.production.min.js 51 B (0%)
packages/types/dist/rich-text-types.esm.js 64 B (0%)

@jpedroschmitz jpedroschmitz merged commit 9d7bead into main Mar 22, 2022
@jpedroschmitz jpedroschmitz deleted the fix-key branch March 22, 2022 10:31
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working react-renderer Issues and PR's related to @graphcms/rich-text-react-renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React duplicate key issue
2 participants