Skip to content

Gradient tool always re-selects its end point after any click/drag #2445

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
0HyperCube opened this issue Mar 16, 2025 · 1 comment · Fixed by #2472
Closed

Gradient tool always re-selects its end point after any click/drag #2445

0HyperCube opened this issue Mar 16, 2025 · 1 comment · Fixed by #2472
Assignees
Labels
Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve
Milestone

Comments

@0HyperCube
Copy link
Member

Reproduce:

  • Draw gradient
  • Try and select a non-end point (i.e. the start or middle)
broken_gradient_selection.mp4

This is because in the (GradientToolFsmState::Drawing, GradientToolMessage::PointerUp) FSM transition, the SelectedGradient::new is called, which sets the selected point to the end one. A regression introduced by #1945.

@0HyperCube 0HyperCube added Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve labels Mar 16, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Mar 16, 2025
@Keavon Keavon changed the title Gradient tool selects end point on mouse up Gradient tool always re-selects its end point after any click/drag Apr 6, 2025
@github-project-automation github-project-automation bot moved this from Short-Term to Completed This Milestone in Task Board Apr 6, 2025
@Sidharth-Singh10
Copy link
Contributor

#2472 fixes this

@Keavon Keavon added this to the Milestone 47 milestone Apr 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve
Projects
Status: Completed This Milestone
Development

Successfully merging a pull request may close this issue.

3 participants