Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exposing a value to the graph should add and connect up an equivalent value node #2447

Open
Keavon opened this issue Mar 17, 2025 · 2 comments
Labels
Good First Issue Good for newcomers Graphene Involves the node graph system/engine used by Graphite

Comments

@Keavon
Copy link
Member

Keavon commented Mar 17, 2025

If you click the dot to expose an input to the graph...

Image

(here, the top one is exposed and the other two are not)

...it removes the control from the Properties panel and puts a connector on the node in the graph.

But that connector starts out connected to nothing. And whatever value the user had typed in the Properties panel previously, isn't represented anymore.

We want to have the process of clicking to expose an input to create a value node in the graph which is set to the same value as the Properties panel had. (This will require the creation of new value nodes, since not all representable Properties panel types have a value node yet.)

As a stretch goal, we also would like the reverse to occur: if a user un-exposes a node, it should evaluate what its current value is and set that to the input in the Properties panel. Perhaps only optionally, though, because the current behavior might be desired some (most?) of the time. This aspect can wait to be figured out or we can break it out into a separate issue.

@Keavon Keavon added Good First Issue Good for newcomers Graphene Involves the node graph system/engine used by Graphite labels Mar 17, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Mar 17, 2025
@Forchapeatl
Copy link

Hello @Keavon , #2434 already has a PR to it , May I work on this issue ?

@Keavon
Copy link
Member Author

Keavon commented Mar 20, 2025

Sure, you're welcome to begin with this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Good First Issue Good for newcomers Graphene Involves the node graph system/engine used by Graphite
Projects
Status: Short-Term
Development

No branches or pull requests

2 participants