Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check map file size for RMT #140

Open
Fort-TM opened this issue Dec 20, 2024 · 1 comment · May be fixed by #147
Open

Check map file size for RMT #140

Fort-TM opened this issue Dec 20, 2024 · 1 comment · May be fixed by #147
Labels
enhancement New feature or request

Comments

@Fort-TM
Copy link
Contributor

Fort-TM commented Dec 20, 2024

Is your feature request related to a problem? Please describe.

When playing on RMT, the plugin can get stuck switching maps sometimes. We theorized in the OP server that one of the issues is that the plugin tries to add a map that exceeds the server limit

Related to #120, but most likely not the only cause of that issue (Xertrov also mentioned a potential race condition when editing the room)

Describe the solution you'd like

The plugin should check for the file size before adding the map, and fetch another map if it exceeds the max size.

Additional context

Here's how the TMX Together plugin checks for the file size. The exact size limit is 7336960 octets, as set here

The TMX API returns the bool "SizeWarning" when getting the map info, which indicates if the map exceeds the size limit. The issue with using this is that Xertrov's API doesn't return this value, so the plugin would still need to manually check the file size when using his API

@Fort-TM Fort-TM added the enhancement New feature or request label Dec 20, 2024
@Fort-TM Fort-TM linked a pull request Feb 18, 2025 that will close this issue
@Fort-TM
Copy link
Contributor Author

Fort-TM commented Feb 18, 2025

Should be fixed with #147, since we won't use Xertrov's API with MX 2.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant