Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: CS #129

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix: CS #129

merged 1 commit into from
Mar 15, 2022

Conversation

vincentchalamon
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #129 (2d34758) into main (652ecf0) will increase coverage by 0.25%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #129      +/-   ##
============================================
+ Coverage     69.40%   69.65%   +0.25%     
  Complexity      262      262              
============================================
  Files            47       42       -5     
  Lines          1157     1104      -53     
============================================
- Hits            803      769      -34     
+ Misses          354      335      -19     
Flag Coverage Δ
phpunit 69.65% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/EnvelopeCreator/GetViewUrl.php 85.71% <ø> (-1.79%) ⬇️
src/EnvelopeCreator/CreateDocument.php 91.66% <0.00%> (-1.67%) ⬇️
src/EnvelopeBuilder.php 26.72% <0.00%> (-1.38%) ⬇️
...entSubscriber/AuthorizationCodeEventSubscriber.php 89.28% <0.00%> (-0.72%) ⬇️
src/DependencyInjection/Configuration.php 97.80% <0.00%> (-0.13%) ⬇️
src/EnvelopeCreator/DefineEnvelope.php 97.67% <0.00%> (-0.06%) ⬇️
src/DependencyInjection/DocusignExtension.php 98.69% <0.00%> (-0.02%) ⬇️
src/Grant/JwtGrant.php 0.00% <0.00%> (ø)
src/Controller/Consent.php 100.00% <0.00%> (ø)
... and 16 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1985455469

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.8%) to 73.964%

Files with Coverage Reduction New Missed Lines %
src/EnvelopeCreator/TraceableEnvelopeBuilderCallableInterface.php 1 0%
src/Filesystem/FilesystemDecorator.php 2 0%
src/Grant/JwtGrant.php 17 0%
Totals Coverage Status
Change from base Build 1734745274: -1.8%
Covered Lines: 696
Relevant Lines: 941

💛 - Coveralls

@vincentchalamon vincentchalamon merged commit d2ff39c into main Mar 15, 2022
@vincentchalamon vincentchalamon deleted the fix/cs branch March 15, 2022 08:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants