Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for ssf2xjr1 #44

Open
MCMic opened this issue Sep 21, 2021 · 3 comments
Open

Support for ssf2xjr1 #44

MCMic opened this issue Sep 21, 2021 · 3 comments

Comments

@MCMic
Copy link

MCMic commented Sep 21, 2021

Hello, following #43 ,
I’m opening this to talk about adding support for ssf2xjr1 rom to the tool, and ask questions I have.

As I explained for starters I am trying to make the input display work.

It works a bit with the attached patch draft.patch.txt

So, questions:

  1. What do you think of the organisation with a roms.lua file containing the rom specific information?
  2. What about rom specific code, for now I put it in the same file because there is only one function but it will be a mess quite soon if we do it like this I think. We should find a nice way to split each rom specific code in a file, and not mix rom information and rom specific code.
  3. When should is_in_match be true? I read an address that differs from 0 only when the players have character control, meaning it becomes true after the «fight!» title, and it goes back to false in between rounds, is that ok?
  4. How were the framedata json file built? Was that recorded with another script? Which features require this framedata?
  5. Is there anything special to know about the character select snapshot or is it just a snapshot of the character select screen of a fresh game? Should both player have pressed start before the snapshot?
@Grouflon
Copy link
Owner

We should probably set up a call on discord to at least kick off all those discussions don't you think ? do you have a discord id ?

@MCMic
Copy link
Author

MCMic commented Sep 21, 2021

We should probably set up a call on discord to at least kick off all those discussions don't you think ? do you have a discord id ?

MCMic#5229 but I can’t have a call today, or maybe late after 9h30 pm.

@ToufaDev
Copy link

I'd like to join the discussion as well : Touakak#7715

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants