Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: formatting #3

Open
Guekka opened this issue Jun 22, 2023 · 1 comment
Open

ci: formatting #3

Guekka opened this issue Jun 22, 2023 · 1 comment

Comments

@Guekka
Copy link
Owner

Guekka commented Jun 22, 2023

Currently, the CI checks for invalid formatting and autocommits fixes. This has several issues:

  • breaks with branch protection rules
  • creates useless commits

Instead, it would be better to reject PRs with invalid formatting, letting the author fix it. We could also add pre-commit hooks

@Guekka
Copy link
Owner Author

Guekka commented Jul 16, 2023

For now, we simply disabled formatting on main branch, since it is protected anyway e409932
May reopen if necessary

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant