From 8a6636243091e6c490c8b010a6db21fd63bc6a20 Mon Sep 17 00:00:00 2001 From: Thomas Karpiniec Date: Sat, 23 Sep 2017 16:04:03 +1000 Subject: [PATCH 1/2] Diagnostic note when matching tuple enum with struct pattern --- src/librustc_typeck/check/_match.rs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/librustc_typeck/check/_match.rs b/src/librustc_typeck/check/_match.rs index cbf58209d056a..d942b2d123070 100644 --- a/src/librustc_typeck/check/_match.rs +++ b/src/librustc_typeck/check/_match.rs @@ -787,11 +787,14 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> { for field in variant.fields .iter() .filter(|field| !used_fields.contains_key(&field.name)) { - struct_span_err!(tcx.sess, span, E0027, - "pattern does not mention field `{}`", - field.name) - .span_label(span, format!("missing field `{}`", field.name)) - .emit(); + let mut diag = struct_span_err!(tcx.sess, span, E0027, + "pattern does not mention field `{}`", + field.name); + diag.span_label(span, format!("missing field `{}`", field.name)); + if variant.ctor_kind == CtorKind::Fn { + diag.note("trying to match a tuple variant with a struct variant pattern"); + } + diag.emit(); } } } From def660cad5c77478c28c3d4092e8d17367050935 Mon Sep 17 00:00:00 2001 From: Thomas Karpiniec Date: Sat, 23 Sep 2017 20:49:28 +1000 Subject: [PATCH 2/2] UI unit test for note when matching tuple enum with struct pattern --- src/test/ui/type-check/issue-41314.rs | 19 +++++++++++++++++++ src/test/ui/type-check/issue-41314.stderr | 16 ++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 src/test/ui/type-check/issue-41314.rs create mode 100644 src/test/ui/type-check/issue-41314.stderr diff --git a/src/test/ui/type-check/issue-41314.rs b/src/test/ui/type-check/issue-41314.rs new file mode 100644 index 0000000000000..5127a8ce17482 --- /dev/null +++ b/src/test/ui/type-check/issue-41314.rs @@ -0,0 +1,19 @@ +// Copyright 2017 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +enum X { + Y(u32) +} + +fn main() { + match X::Y(0) { + X::Y { number } => {} + } +} diff --git a/src/test/ui/type-check/issue-41314.stderr b/src/test/ui/type-check/issue-41314.stderr new file mode 100644 index 0000000000000..acae7a350877a --- /dev/null +++ b/src/test/ui/type-check/issue-41314.stderr @@ -0,0 +1,16 @@ +error[E0026]: variant `X::Y` does not have a field named `number` + --> $DIR/issue-41314.rs:17:16 + | +17 | X::Y { number } => {} + | ^^^^^^ variant `X::Y` does not have field `number` + +error[E0027]: pattern does not mention field `0` + --> $DIR/issue-41314.rs:17:9 + | +17 | X::Y { number } => {} + | ^^^^^^^^^^^^^^^ missing field `0` + | + = note: trying to match a tuple variant with a struct variant pattern + +error: aborting due to 2 previous errors +