Skip to content

Commit 90b2657

Browse files
authored
Fix the admin mailer config display (go-gitea#20633)
1 parent 2754ecc commit 90b2657

File tree

2 files changed

+19
-9
lines changed

2 files changed

+19
-9
lines changed

options/locale/locale_en-US.ini

+6-3
Original file line numberDiff line numberDiff line change
@@ -2796,16 +2796,19 @@ config.queue_length = Queue Length
27962796
config.deliver_timeout = Deliver Timeout
27972797
config.skip_tls_verify = Skip TLS Verification
27982798

2799-
config.mailer_config = SMTP Mailer Configuration
2799+
config.mailer_config = Mailer Configuration
28002800
config.mailer_enabled = Enabled
2801-
config.mailer_disable_helo = Disable HELO
2801+
config.mailer_enable_helo = Enable HELO
28022802
config.mailer_name = Name
2803-
config.mailer_host = Host
2803+
config.mailer_protocol = Protocol
2804+
config.mailer_smtp_addr = SMTP Addr
2805+
config.mailer_smtp_port = SMTP Port
28042806
config.mailer_user = User
28052807
config.mailer_use_sendmail = Use Sendmail
28062808
config.mailer_sendmail_path = Sendmail Path
28072809
config.mailer_sendmail_args = Extra Arguments to Sendmail
28082810
config.mailer_sendmail_timeout = Sendmail Timeout
2811+
config.mailer_use_dummy = Dummy
28092812
config.test_email_placeholder = Email (e.g. test@example.com)
28102813
config.send_test_mail = Send Testing Email
28112814
config.test_mail_failed = Failed to send a testing email to '%s': %v

templates/admin/config.tmpl

+13-6
Original file line numberDiff line numberDiff line change
@@ -218,12 +218,7 @@
218218
{{if .MailerEnabled}}
219219
<dt>{{.locale.Tr "admin.config.mailer_name"}}</dt>
220220
<dd>{{.Mailer.Name}}</dd>
221-
{{if eq .Mailer.MailerType "smtp"}}
222-
<dt>{{.locale.Tr "admin.config.mailer_disable_helo"}}</dt>
223-
<dd>{{if .DisableHelo}}{{svg "octicon-check"}}{{else}}{{svg "octicon-x"}}{{end}}</dd>
224-
<dt>{{.locale.Tr "admin.config.mailer_host"}}</dt>
225-
<dd>{{.Mailer.Host}}</dd>
226-
{{else if eq .Mailer.MailerType "sendmail"}}
221+
{{if eq .Mailer.Protocol "sendmail"}}
227222
<dt>{{.locale.Tr "admin.config.mailer_use_sendmail"}}</dt>
228223
<dd>{{svg "octicon-check"}}</dd>
229224
<dt>{{.locale.Tr "admin.config.mailer_sendmail_path"}}</dt>
@@ -232,6 +227,18 @@
232227
<dd>{{.Mailer.SendmailArgs}}</dd>
233228
<dt>{{.locale.Tr "admin.config.mailer_sendmail_timeout"}}</dt>
234229
<dd>{{.Mailer.SendmailTimeout}} {{.locale.Tr "tool.raw_seconds"}}</dd>
230+
{{else if eq .Mailer.Protocol "dummy"}}
231+
<dt>{{.locale.Tr "admin.config.mailer_use_dummy"}}</dt>
232+
<dd>{{svg "octicon-check"}}</dd>
233+
{{else}}{{/* SMTP family */}}
234+
<dt>{{.locale.Tr "admin.config.mailer_protocol"}}</dt>
235+
<dd>{{.Mailer.Protocol}}</dd>
236+
<dt>{{.locale.Tr "admin.config.mailer_enable_helo"}}</dt>
237+
<dd>{{if .Mailer.EnableHelo}}{{svg "octicon-check"}}{{else}}{{svg "octicon-x"}}{{end}}</dd>
238+
<dt>{{.locale.Tr "admin.config.mailer_smtp_addr"}}</dt>
239+
<dd>{{.Mailer.SMTPAddr}}</dd>
240+
<dt>{{.locale.Tr "admin.config.mailer_smtp_port"}}</dt>
241+
<dd>{{.Mailer.SMTPPort}}</dd>
235242
{{end}}
236243
<dt>{{.locale.Tr "admin.config.mailer_user"}}</dt>
237244
<dd>{{if .Mailer.User}}{{.Mailer.User}}{{else}}(empty){{end}}</dd><br>

0 commit comments

Comments
 (0)