Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider sending an array of preLen sizes to StructureSupport classes for sanity checks #335

Open
jesse-gallagher opened this issue May 2, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request investigation Tasks that require investigation or consideration before deciding what work, if any, is involved

Comments

@jesse-gallagher
Copy link
Collaborator

This is essentially an expansion of #333

The trouble here is that there's a reasonable chance that one "Len" component of a structure may be corrupt - seen in practice as presumably a negative value. Our current idiom is to add all these values and then pass them to StructureSupport, but doing so means that we have no way to detect likely corruption. Naturally, we can't detect all corruption: if the value is 3 but should be 2 or 4, there's no real way to tell what's corrupt, but we COULD see if an individual component is negative or larger than the total size. This would cover for the plausible case of the structure being created with uninitialized memory and then only some "Len" components set.

@jesse-gallagher jesse-gallagher added enhancement New feature or request investigation Tasks that require investigation or consideration before deciding what work, if any, is involved labels May 2, 2022
@jesse-gallagher jesse-gallagher self-assigned this May 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request investigation Tasks that require investigation or consideration before deciding what work, if any, is involved
Projects
None yet
Development

No branches or pull requests

1 participant