Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove the concept of the PROJECT_ROOT #102

Closed
csala opened this issue May 4, 2018 · 1 comment · Fixed by #141
Closed

Remove the concept of the PROJECT_ROOT #102

csala opened this issue May 4, 2018 · 1 comment · Fixed by #141
Assignees
Milestone

Comments

@csala
Copy link
Contributor

csala commented May 4, 2018

No python code should have to rely on its location, so having to declare a PROJECT_ROOT variable in the main package is a sign of weak points in the project.

In any case, any path variables should be computed in the scripts that use the atm package, not within it.

@micahjsmith
Copy link
Member

This goes hand-in-hand with an approach to rethink how configuration is supplied for the project.

Here is an example from Apache Airflow:

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants