Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No mention of linking TBB libraries in "Making things parallel" #32

Closed
ppp2211 opened this issue Oct 7, 2017 · 4 comments
Closed

No mention of linking TBB libraries in "Making things parallel" #32

ppp2211 opened this issue Oct 7, 2017 · 4 comments

Comments

@ppp2211
Copy link

ppp2211 commented Oct 7, 2017

I'm working through the guide right now, and I got slightly stuck on the "Making things parallel" part with the compiler spitting out a large list of tbb-related errors.

Then, with help of Google, I realised I'm not importing the TBB libraries into the compiler. A quick look in the makefile confirmed my suspicion - "LDLIBS += -ltbb" is commented out by default, and there's no mention of this in the tutorial.

I feel like it would be a good idea to add a sentence reminding us to go back and update the makefile before trying to recompile for TBB, unless this is a deliberate attempt to make people learn how to debug (i.e. Google the errors).

@Matthewar
Copy link

Is there anything mentioning installing the library too? I had to find the repo for ubuntu (which turned out to be libtbb-dev), but I couldn't see it mentioned anywhere - that might also be useful since some people won't have used the linux package manager much.

@ppp2211
Copy link
Author

ppp2211 commented Oct 8, 2017

Yes - that is under "Choose a platform" -> "Installing libraries". At least in the Linux platform description, haven't bothered checking any other ones.

Different distros will have different TBB package names, but the Ubuntu/Debian one is actually listed. For Arch it was intel-tbb.

@m8pple
Copy link
Contributor

m8pple commented Oct 9, 2017

That looks like a regression on my part, as I don't think it was a problem last time. The reason
for having it un-commented to start with is that it allows people to get started before getting
TBB installed. It used to be that compiling TBB was part of the spec, but this was too much for
a lot of people.

I'll update the instructions, as it is definitely a non-obvious step for most people and should
be in there.

Thanks.

@m8pple
Copy link
Contributor

m8pple commented Oct 9, 2017

(Leaving the issue open for a while, so that people can see it.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants