Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ControlNet 1.1+ Compatibility #317

Open
dunkeroni opened this issue May 18, 2023 · 1 comment
Open

ControlNet 1.1+ Compatibility #317

dunkeroni opened this issue May 18, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dunkeroni
Copy link

The newer ControlNet options available in 1.1 and onwards offer a level of complexity that the Horde is not currently able to utilize. In addition to having more model types in general, there are also preprocessors that do not use a model (e.g. reference_only mode that allows recreating subjects based on an input image) as well as models that do not rely on preprocessors (e.g. experimental Tile model that allows tile-based upscaling without introducing repetition artifacts). New models are architecturally the same as before, so ComfyUI already supports them. Just the Horde is not conducive to adding new CN features in its current state.

At minimum, the inputs for ControlNet operations should be separated configurable parts of the request, and recommended setups can be handled on the frontends. Ideally it should align with whatever plans are in place for the Horde server side to handle future Comfy pipelines.

GenerationInputStable {
  ...,
  params {
    ...,
    ComfyProcess {
      process_type: "ControlNet",
      controlnet_preprocessor: <string>,
      controlnet_model: <string>,
      controlnet_strength: <number>,
      controlnet_img: <encoded webp>
      controlnet_return_control_map: <boolean>
@tazlin tazlin added the enhancement New feature or request label May 30, 2023
@tazlin tazlin transferred this issue from Haidra-Org/AI-Horde-Worker Aug 26, 2024
@tazlin tazlin transferred this issue from Haidra-Org/horde-worker-reGen Aug 26, 2024
@tazlin
Copy link
Member

tazlin commented Aug 26, 2024

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants