Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Shouldn't show when press Cmd+C etc.. #48

Open
aquarhead opened this issue Nov 27, 2013 · 5 comments
Open

Shouldn't show when press Cmd+C etc.. #48

aquarhead opened this issue Nov 27, 2013 · 5 comments
Labels

Comments

@aquarhead
Copy link
Member

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ghost
Copy link

ghost commented Nov 27, 2013

Do you mean the instant query pops up when pressing Cmd + C?

@xhacker
Copy link
Member

xhacker commented Nov 28, 2013

@marknv: Yeah and sometimes the query is triggered when using Cmd + click to open link.

@ghost
Copy link

ghost commented Nov 28, 2013

@xhacker Hi bro,

Please check lookup.js (line: 159), if (!e.ctrlKey && !e.metaKey), the metaKey is cmd key in mac.

However, personally I don't think it is a bug, since:

  1. In mac, an instant query is triggered when you press cmd or ctrl, and highlight certain text (by dragging or double clicking) at the same time. Only if you double click that link, which may cause highlighting the link text (I do not have this problem), then a query will be triggered.
  2. Ctrl + left click in mac equals to right click, so it is much more convenient to use cmd key in mac. Therefore, please do use both ctrlKey and metaKey.

@xhacker
Copy link
Member

xhacker commented Nov 28, 2013

@marknv: Hi,

Just checked the code, got the problem. Please try: first select a word, then Cmd + click a link. This will trigger unexpected query.

I have two ideas, first is to use option key on Mac. Second is to detect whether the user is pressing modifier key on mouse down. If negative, ignores further mouse up event.

@aquarhead: Could you provide detailed steps to reproduce the Cmd + C issue?

@aquarhead
Copy link
Member Author

@xhacker it triggers randomly (could be my computer's problem

@ghost ghost removed the Critical label Feb 1, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants