Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Always show word that will be typed as middle word in suggestions row #658

Closed
micahmo opened this issue Apr 7, 2024 · 8 comments · Fixed by #739
Closed

Always show word that will be typed as middle word in suggestions row #658

micahmo opened this issue Apr 7, 2024 · 8 comments · Fixed by #739
Labels
enhancement New feature or request PR Contributors are encouranged to submit a pull request. Just ask in case you are interested.

Comments

@micahmo
Copy link

micahmo commented Apr 7, 2024

Is your feature request related to a problem? Please describe.

Apologies if this issue is already opened (I looked through everything, but couldn't find it). I have a bit of an odd request. I would like to see the word that will be selected when I press space as the middle word in the suggestions row always. This means if I type a word correctly and auto-correct will not be applied (i.e. middle word is not bolded), then I see the word I typed on the suggestions row anyway. The problem with the current behavior is that I have to look in two places (the text input area and the suggestions row) to see what word will ultimately be typed. If this feature is implemented, we can type only by looking at suggestions row and always know what word is typed. It's a small thing but it definitely slows down typing as I look back and forth. For comparison, SwiftKey worked this way. I hope it makes sense.

Describe the solution you'd like

See above.

Use case

See above.

Describe alternatives you've considered

The alternative is to get used to looking back and forth between text input area and suggestions row.

Additional context

Just a huge thanks for HeliBoard!! ❤️

@micahmo micahmo added the enhancement New feature or request label Apr 7, 2024
@Helium314 Helium314 added the PR Contributors are encouranged to submit a pull request. Just ask in case you are interested. label Apr 7, 2024
@ghost
Copy link

ghost commented Apr 8, 2024

There's a slight workaround for tap typing. That's to run words together, don't input a space, and then you will have multiple words suggested. Gesture input doesn't do this, of course, but it has flow preview.

@micahmo
Copy link
Author

micahmo commented Apr 10, 2024

Very small change in the code is required to make the typed word appear in the middle if there is no auto correction

I'm glad to hear that!

Should it be optional or is it the expected behavior by most people?

It is the behavior of SwiftKey, but it is not the behavior of GBoard. I guess it should probably be off by default. But of course others can chime in as well!

@Helium314
Copy link
Owner

@codokie maybe you want to discuss with the creator of #665
It should definitely be optional. My experience is that most such changes trigger issues to revert to previous behavior.

@Volterxien
Copy link
Contributor

Not my issue but I would be inclined to agree that it is unlikely to be a welcome change for all users. The more customization options the better, imo

@Volterxien
Copy link
Contributor

Yeah that makes a lot of sense. I hadn't considered lack of autocorrect. I've always had it on, personally lol

@Helium314
Copy link
Owner

Does anyone have a good idea how to name the setting, so it is short and clear enough?
see #672 (comment)

@ghost
Copy link

ghost commented Apr 12, 2024

Does anyone have a good idea how to name the setting, so it is short and clear enough? see #672 (comment)

  • Focus Suggestion
  • Always focus suggestion
  • Center focus suggestion
  • Center preview
  • Focus center preview

🤷‍♂️

I also think that where the setting shows up helps clarify greatly what it's for and does. Like in glide typing we have "dynamic floating preview" so it's painfully obvious it has to do with glide typing and not regular autocorrect.

The two main words are "suggestion" and "preview" IMO. Then preference on modifiers — always, center, focused, etc.

So, is it a suggestion or a preview? I think it becomes a preview just like the glide typing floating preview whereas otherwise it's a suggestion for autocorrect.

That's the way my peanut thinks about it. 😁

Hopefully others will chime in.

@Helium314 Helium314 linked a pull request May 1, 2024 that will close this issue
@micahmo
Copy link
Author

micahmo commented Jun 26, 2024

Hey I just wanted to drop a comment here and mention that I just started using this feature now (due to the stable release of 2.0), and it works great. Thanks to everyone who helped to implement it!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request PR Contributors are encouranged to submit a pull request. Just ask in case you are interested.
Projects
None yet
3 participants