Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Format versioning for model artifacts #73

Open
Waino opened this issue May 27, 2024 · 0 comments
Open

Format versioning for model artifacts #73

Waino opened this issue May 27, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Waino
Copy link
Collaborator

Waino commented May 27, 2024

A version number should be stored in the model save files (checkpoints).
Whenever a code change affects the format of the save files, the version should be incremented.
When loading a save file with a version that is older than the current version:

  • Log a warning including the version in the save file.
  • Perhaps attempt to transform the format to be compatible. Such compatibility code becomes clearer to read and easier to remove once obsolete, because it is enclosed in a condition on the save format version.
  • If recovery is impossible with the current code, throw an exception. It is easy to roll back to a commit with the appropriate format version, to allow decoding or continued training.
@Waino Waino added enhancement New feature or request good first issue Good for newcomers labels May 27, 2024
@Waino Waino changed the title Versioning for model artifacts Format versioning for model artifacts May 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant