Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure that all existing code handles cases of missing data with graceful partial failure #17

Closed
joehandzik opened this issue Apr 20, 2017 · 2 comments

Comments

@joehandzik
Copy link
Contributor

Essentially, avoid the same situation we ran into with weirdly missing data from the stats file.

@joehandzik
Copy link
Contributor Author

@roclark I took a look at this yesterday and didn't see anything, expect for maybe in the brw_stats parser. Can you double check that and, if you think there's no problem, close out this issue? Specific line to start at (I think): https://github.com/HewlettPackard/lustre_exporter/blob/master/sources/procfs.go#L455

@roclark
Copy link
Contributor

roclark commented Apr 28, 2017

We are good on BRW stats due to how the metrics are written (we get all or nothing). Since the metricMap is allocated at the top of the function where we actually parse data, there isn't a concern about accessing invalid memory.

@roclark roclark closed this as completed Apr 28, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants