Skip to content

Feature Request: adapt name includes parentheses string #125

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
tkow opened this issue Feb 11, 2024 · 1 comment · Fixed by #126
Closed

Feature Request: adapt name includes parentheses string #125

tkow opened this issue Feb 11, 2024 · 1 comment · Fixed by #126
Labels
Type: Bug Something isn't working

Comments

@tkow
Copy link
Contributor

tkow commented Feb 11, 2024 •
edited
Loading

Steps To Reproduce

Run bun i && bun gen.ts in https://github.com/tkow/cloudflare-ts-client.

This spec includes parentheses in operationId , which is valid though It's not recommended in OAS 3.0.3.
operationId: secondary-dns-(-primary-zone)-create-primary-zone-configuration

The current behavior

See generated codes from a coudflare spec.
https://github.com/tkow/cloudflare-ts-client/blob/main/src/client.ts

The expected behavior

Sanitize them to valid function name.
@tkow tkow added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Feb 11, 2024
@tkow tkow changed the title Bug: generator function name includes parentheses string Feature Request: generator function name includes parentheses string Feb 11, 2024
@tkow tkow changed the title Feature Request: generator function name includes parentheses string Feature Request: adapt name includes parentheses string Feb 11, 2024
@Himenon Himenon mentioned this issue Feb 11, 2024
Merged
@Himenon Himenon added Type: Bug Something isn't working and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Feb 11, 2024
@Himenon
Copy link
Owner

Himenon commented Feb 11, 2024 •
edited
Loading

@tkow Thanks for the report!

This problem has been fixed in v1.0.6.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sanitize regex pattern Himenon/openapi-typescript-code-generator
2 participants
@Himenon @tkow