From 23274ac4546ffca817b913535c7f672d7add1178 Mon Sep 17 00:00:00 2001 From: Sam Ford <1584702+samford@users.noreply.github.com> Date: Tue, 4 Feb 2025 16:05:35 -0500 Subject: [PATCH] tests: add missing :needs_network argument I was recently running `brew tests` without `--online` and I noticed that there was still one formulae.brew.sh request. I narrowed it down to a `brew desc` test, so this adds `:needs_network` to that test. As expected, `brew tests` doesn't make any network requests after this change unless `--online` is used. --- Library/Homebrew/test/cmd/desc_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/test/cmd/desc_spec.rb b/Library/Homebrew/test/cmd/desc_spec.rb index 270ec55c14a42..4313e56ac32ec 100644 --- a/Library/Homebrew/test/cmd/desc_spec.rb +++ b/Library/Homebrew/test/cmd/desc_spec.rb @@ -31,7 +31,7 @@ .and not_to_output.to_stderr end - it "successfully searches without --eval-all, with API", :integration_test do + it "successfully searches without --eval-all, with API", :integration_test, :needs_network do setup_test_formula "testball" expect { brew "desc", "--search", "testball", "HOMEBREW_NO_INSTALL_FROM_API" => nil }