brew --repository now prefixes "homebrew-" to tap directory

[mattlqx]

brew doctor output

Warning: Some installed formulae are missing dependencies.
You should `brew install` the missing dependencies:
  brew install ffmpeg@6

Run `brew missing` for more details.

Verification

• My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
• I ran brew update twice and am still able to reproduce my issue.
• This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output

HOMEBREW_VERSION: 4.3.9-376-gcc32d08
ORIGIN: https://github.com/Homebrew/brew
HEAD: cc32d08c41a85fee405aeff9fab434beeb910922
Last commit: 4 hours ago
Core tap HEAD: c2a544d67812a71d8269f41192b9289592d7099b
Core tap last commit: 43 minutes ago
Core tap JSON: 24 Jul 22:02 UTC
Core cask tap HEAD: 84844865c5dd6079f7aaf5579ebaf88fb8babbe5
Core cask tap last commit: 4 minutes ago
Core cask tap JSON: 24 Jul 22:02 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: vim
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4/bin/ruby
CPU: dodeca-core 64-bit arm_blizzard_avalanche
Clang: 15.0.0 build 1500
Git: 2.39.3 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 8.6.0 => /usr/bin/curl
macOS: 14.5-arm64
CLT: 15.3.0.0.1.1708646388
Xcode: 15.4
Rosetta 2: false

What were you trying to do (and why)?

Run brew --repository to get the tap path.

What happened (include all command output)?

➜ brew --repository foo/homebrew-bar                                                                               
/opt/homebrew/Library/Taps/foo/homebrew-homebrew-bar

What did you expect to happen?

Prior to #17726 , brew --repository foo/homebrew-bar yielded (on an Apple Silicon Mac):

/opt/homebrew/Library/Taps/foo/homebrew-bar

Step-by-step reproduction instructions (by running brew commands)

It now yields an additional `homebrew-` prefix:

1. Run brew --repository foo/homebrew-bar
2. Observe a non-existent path.