-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add audit for wayback machine URLs #16476
feat: add audit for wayback machine URLs #16476
Conversation
a190780
to
b308bf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea, thanks @SMillerDev!
How do we want to deal with formulae with dependents? For example, Some options being:
EDIT: This may depend on upcoming discussion for updating/formalizing how to consistently handle deprecation. |
@cho-m Good questions! I think it's worth talking about this at the AGM. I think |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
We did not talk about this at the AGM, but I think if we depend on something we have no other way than to adopt maintenance of it. There are also a bunch of formula that use Debian as a source now as an alternative, since they cache all the source code of their packages. |
I don't think so. It doesn't make sense to me to deprecate a formula but not the dependents. |
I'll move forward with this, switching sources to a "maintained" version whenever I can. Deprecating otherwise. |
a673728
to
b48e0ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once CI
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Right, still have to finish the list of deprecations in core. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Core depreciations are still ongoing, it's taking some effort |
@SMillerDev How about making this strict and/or for new formulae only so it can get merged before homebrew/core is all fixed? |
Not sure if it'll catch anything that way, but it's certainly a way to get this merged now |
Yeh, I think getting it merged/runnable sooner would be better. |
f069cea
to
50d5333
Compare
50d5333
to
5e6f90f
Compare
Thanks again @SMillerDev! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?