fix: Display a warning (instead of exiting early) when unable to find recent issues on a tap

[boblail]

Occasionally, when failing to brew install or brew upgrade a formula, users will get an error message and the last line of it will be:

Error: Validation Failed: [{"message"=>"The listed users and repositories cannot be searched either because the resources do not exist or you do not have permission to view them.", "resource"=>"Search", "field"=>"q", "code"=>"invalid"}]

Here's an old public example: https://gitlab.com/tabos/rogerrouter/-/issues/21

At Square, this error can be caused by a transient issue with a user's GitHub credentials.

My proposal is that any error which prevents brew from showing related issues should:

1. Not cause brew to exit early (vs. printing diagnostic checks and doing any other cleanup)
2. Be clearly differentiated from the original failure (so it doesn't become a red herring for users troubleshooting their broken formula)

---

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

[boblail]

Added text to the beginning of the error message to explain that the error isn't related to the original exception

[apainintheneck]

This makes perfect sense to me. There is no reason we should be failing inside an error while querying Github so catching all Github API errors is reasonable. It's only used to print some extra debug information anyway so skipping it isn't the end of the world if the request fails for some reason.

It seems to only be used here.

brew/Library/Homebrew/exceptions.rb

Lines 543 to 546 in c2ed332

	if issues.present?
	puts "These open issues may also help:"
	puts issues.map { |i| "#{i["title"]} #{i["html_url"]}" }.join("\n")
	end

[carlocab]

Thanks!

[MikeMcQuaid]

Thanks again @boblail!

[boblail]

Thanks all!