Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Display a warning (instead of exiting early) when unable to find recent issues on a tap #17182

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: Display a warning (instead of exiting early) when unable to find recent issues on a tap #17182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Library/Homebrew/exceptions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,8 @@
sig { returns(T::Array[T.untyped]) }
def fetch_issues
GitHub.issues_for_formula(formula.name, tap: formula.tap, state: "open", type: "issue")
rescue GitHub::API::RateLimitExceededError => e
opoo e.message
rescue GitHub::API::Error => e
opoo "Unable to query GitHub for recent issues on the tap\n#{e.message}"

Check warning on line 494 in Library/Homebrew/exceptions.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/exceptions.rb#L494 

Added line #L494 was not covered by tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added text to the beginning of the error message to explain that the error isn't related to the original exception

[]
end

Expand Down