Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove disabled extend. #17184

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Apr 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is disabled on any platform regardless.

@MikeMcQuaid
Copy link
Member

Normally would wait around to remove this but: it's a private API anyway.

@MikeMcQuaid MikeMcQuaid enabled auto-merge April 30, 2024 09:07
@MikeMcQuaid
Copy link
Member

Thanks again @reitermarkus!

@reitermarkus
Copy link
Member Author

reitermarkus commented Apr 30, 2024

It's still odisabled in Tap unconditionally.

@MikeMcQuaid
Copy link
Member

It's still odisabled in Tap unconditionally.

Ah, nice, great 👍🏻

@MikeMcQuaid MikeMcQuaid merged commit c9c8806 into Homebrew:master Apr 30, 2024
25 checks passed
@reitermarkus reitermarkus deleted the unneeded-extend branch May 1, 2024 09:43
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants